Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve localization #373

Merged
merged 9 commits into from
Aug 5, 2024
Merged

Improve localization #373

merged 9 commits into from
Aug 5, 2024

Conversation

shindgewongxj
Copy link
Contributor

No description provided.

Cork/Localizable.xcstrings Outdated Show resolved Hide resolved
@Jerry23011
Copy link
Collaborator

Jerry23011 commented Aug 5, 2024

Please refer to this commit (ba04766)

\n means a line break. You can use ⌥ ↩ to insert a line break.

@Jerry23011 Jerry23011 self-requested a review August 5, 2024 10:48
@Jerry23011
Copy link
Collaborator

Since Cork is an open-source software, I'm using 你 instead of 您(what would be usually used in closed-source commercial apps) b199e77

拷贝 is the right term for copy in Chinese, Windows has been misleading us for decades by translating it into 复制 (duplicate), thanks a lot Microsoft. :)

Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Love your translations with JSON parsing, couldn't do so well if it were me translating. 🫶

@Jerry23011
Copy link
Collaborator

感谢!@shindgewongxj

@Jerry23011 Jerry23011 merged commit 3369bcb into buresdv:main Aug 5, 2024
@shindgewongxj
Copy link
Contributor Author

感谢!@shindgewongxj

非常感谢你帮助我完善和修正这些被我忽略掉的细节,将会在后续的本地化中注意这一部分!🫡 再次感谢!@Jerry23011

@buresdv
Copy link
Owner

buresdv commented Aug 5, 2024

我的兄弟们,你们做的饭菜真好吃 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants