Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add .swiftlint.yml #386

Closed
wants to merge 1 commit into from
Closed

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 19, 2024

Related to:

Requested at #378 (comment)

https://github.com/realm/SwiftLint?tab=readme-ov-file#configuration

% swiftlint --fix can automatically fix:

  • comment_spacing
  • duplicate_imports
  • empty_enum_arguments
  • redundant_optional_initialization
  • redundant_void_return
  • statement_position
  • trailing_comma
  • trailing_whitespace
  • type_body_length
  • unused_closure_parameter
  • unused_enumerated
  • vertical_whitespace

@buresdv
Copy link
Owner

buresdv commented Aug 19, 2024

Thanks, I already have a swiftlint config in another branch, see here: https://github.com/buresdv/Cork/blob/main.swiftlint/.swiftlint.yml

Could you please use that one instead? The code in branch main.swiftlint is already fixed for this config, and this config will be used in the future

@cclauss
Copy link
Contributor Author

cclauss commented Aug 19, 2024

Cool! You are way ahead of me. Closing.

Once https://github.com/buresdv/Cork/blob/main.ci/.github/workflows/swift.yml and https://github.com/buresdv/Cork/blob/main.swiftlint/.swiftlint.yml on the same branch things will be easier to work with.

@cclauss cclauss closed this Aug 19, 2024
@cclauss cclauss deleted the Add-.swiftlint.yml branch August 19, 2024 11:53
@buresdv
Copy link
Owner

buresdv commented Aug 19, 2024

WE were thinking of the same thing with Swiftlint 😂

@buresdv
Copy link
Owner

buresdv commented Aug 19, 2024

@cclauss By the way, do you have any other experience with GitHub CI and releasing macOS apps? I've been trying to create a CI/CD pipeline for automatically compiling and stapling new versions, but I could never get it working. It's on the branch ci (not to be confused with main.ci)

@cclauss
Copy link
Contributor Author

cclauss commented Aug 19, 2024

I have tons of experience with GitHub CI and I used to release macOS apps in the olden days. I will look into it tomorrow.

@buresdv
Copy link
Owner

buresdv commented Aug 19, 2024

Thanks a lot, I'd really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants