fix: Installed-Size #160
Merged
fix: Installed-Size #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdsteele
reviewed
Sep 25, 2023
src/bundle/linux/deb_bundle.rs
Outdated
| writeln!( | ||
| &mut file, | ||
| "Installed-Size: {}", | ||
| total_dir_size(data_dir)? / 1024 |
There was a problem hiding this comment.
From the doc you linked, looks like this is supposed to be total size / 1024, rounded up? This is currently rounding down.
One way to do this would be to write (total_dir_size(data_dir)? + 1023) / 1024 (see https://stackoverflow.com/a/2745086). Or I guess you could cast to float and use ceil().
There was a problem hiding this comment.
I'd rather not cast as float, the SO solution looks good
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed wrong calculation of Installed-Size in control file