Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check button property and modifier key states before calling preventDefault() #473

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Check button property and modifier key states before calling preventDefault() #473

merged 1 commit into from
Nov 16, 2020

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Nov 16, 2020

Resolves #6

@Turbo87 Turbo87 added the bug Something isn't working label Nov 16, 2020
buschtoens
buschtoens approved these changes Nov 16, 2020
View reviewed changes
Copy link
Owner

@buschtoens buschtoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌
Thanks a lot!

@buschtoens
Copy link
Owner

The CI failure for canary and beta is also occurring on other PRs, so I don't think this is a merge or release blocker. Will investigate later.

@buschtoens buschtoens merged commit 17122c4 into buschtoens:master Nov 16, 2020
@buschtoens
Copy link
Owner

buschtoens commented Nov 16, 2020 •
edited by unfurl-links bot
Loading

Released in https://github.com/buschtoens/ember-link/releases/tag/v1.2.1. 🥳

GitHub
🐛 Bug Fix

#473 Check button property and modifier key states before calling preventDefault() (@Turbo87)

Committers: 1

Tobias Bieniek (@Turbo87)

@unfurl-links unfurl-links bot mentioned this pull request Nov 16, 2020
Closed
@Turbo87 Turbo87 mentioned this pull request Nov 26, 2020
Merged
@Turbo87 Turbo87 deleted the middle-click branch January 27, 2021 15:38
@Turbo87 Turbo87 mentioned this pull request Feb 25, 2021
Merged
buschtoens pushed a commit that referenced this pull request Mar 9, 2021
@Turbo87
docs(README): Remove obsolete TODO (#542)
b73cc27 
It was implemented in #473.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buschtoens buschtoens buschtoens approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle Cmd / Ctrl click to open in a new tab
2 participants
@Turbo87 @buschtoens