Fix publiclinks and decomposedfs (cs3org#2445)

* decomposedfs: don't check id's containing "/" Signed-off-by: jkoberg <[email protected]> * add changelog Signed-off-by: jkoberg <[email protected]>
butonic · Feb 14, 2022 · b061960 · b061960
1 parent c4d0c64
commit b061960
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/changelog/unreleased/fix-id-checking-in-decomposedfs.md b/changelog/unreleased/fix-id-checking-in-decomposedfs.md
@@ -0,0 +1,8 @@
+Bugfix: Don't handle ids containing "/" in decomposedfs
+
+The storageprovider previously checked all ids without checking their validity
+this lead to flaky test because it shouldn't check ids that are used from the
+public storage provider
+
+https://github.com/cs3org/reva/pull/2445
+
diff --git a/pkg/storage/utils/decomposedfs/spaces.go b/pkg/storage/utils/decomposedfs/spaces.go
@@ -25,6 +25,7 @@ import (
 	"os"
 	"path/filepath"
 	"strconv"
+	"strings"
 
 	userv1beta1 "github.com/cs3org/go-cs3apis/cs3/identity/user/v1beta1"
 	v1beta11 "github.com/cs3org/go-cs3apis/cs3/rpc/v1beta1"
@@ -195,6 +196,9 @@ func (fs *Decomposedfs) ListStorageSpaces(ctx context.Context, filter []*provide
 			}
 		case provider.ListStorageSpacesRequest_Filter_TYPE_ID:
 			spaceID, nodeID, _ = utils.SplitStorageSpaceID(filter[i].GetId().OpaqueId)
+			if strings.Contains(nodeID, "/") {
+				return []*provider.StorageSpace{}, nil
+			}
 		}
 	}
 	if len(spaceTypes) == 0 {