Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #182 (Soda Dark 3, icons AND arrows) #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kronuz
Copy link

@Kronuz Kronuz commented Jun 10, 2014

  • Sidebar tree with row_padding of [0, 3]
    Removes extra padding
  • Sidebar group closed with content_margin of [0, 8]
    Removes arrows (and leaves just folders)
  • Sidebar file icons with content_margin of [0, 8]
    Removes extra padding in files inside folders
    (making them look as if they were a level deeper than they are)

* Sidebar tree with row_padding of [0, 3]
  Removes extra padding

* Sidebar group closed with content_margin of [0, 8]
  Removes arrows (and leaves just folders)

* Sidebar file icons with content_margin of [0, 8]
  Removes extra padding in files inside folders
  (making them look as if they were a level deeper than they are)
@bobrocke
Copy link

This looks like just what I need! I hope it can be merged soon.

@bobrocke
Copy link

@Kronuz If I wanted to make this change myself in the meantime, are there any instruction for messing with theme files? Or would you be willing to email me your patched version?

@buymeasoda
Copy link
Owner

I'll take a look at this merge.

In the interim, Sublime Text has a very nice built in way to customize an existing theme for tweaks and adjustments, without having to mess with the installed theme.

Check out:
https://github.com/buymeasoda/soda-theme/wiki/Theme-customisation

@bobrocke
Copy link

The customization link was helpful. But I'm still new at this.

I put

// Sidebar tree
{
    "class": "sidebar_tree",
    "row_padding": [0, 3]
},
// Sidebar group closed
{
    "class": "disclosure_button_control",
    "content_margin": [0, 8]
},
// Sidebar file icons
{
    "class": "icon_file_type",
    "content_margin": [0, 8]
},

in ~/Library/Application Support/Sublime Text 3/Packages/User/Soda Dark 3.sublime-theme and restarted Sublime Text 3. But nothing changed in the display.

Where did I go wrong?

@buymeasoda
Copy link
Owner

Have you got the entire rules block wrapped in [ ]?

[
    // your customisations
]

Also, if you open the Sublime console (CTRL + ~ on Mac) after you restart, you will see errors encountered by the app. Theme parsing rules output notices to this console to help debug.

I tried adding your rules with the brackets and it works, so that's probably the go.

@bobrocke
Copy link

Perfect! That was it. Thanks!

That also eliminated the arrows, leaving just the icons. What if I wanted the opposite; leave the arrows and eliminate the icons?

@Nerian
Copy link

Nerian commented Jul 14, 2014

What if I wanted the opposite; leave the arrows and eliminate the icons?

That's what I want :) How can we do that?

@AbeEstrada
Copy link

@bobrocke & @Nerian for the opposite you can use this:

[
    {
        "class": "icon_file_type",
        "content_margin": [0,0]
    },
    {
        "class": "icon_folder",
        "content_margin": [0,0]
    },
    {
        "class": "icon_folder_loading",
        "content_margin": [0,0]
    },
]

@Nerian
Copy link

Nerian commented Aug 13, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants