Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiGrid alignment when scrolled to far-right or bottom #535

Closed
andrewdavey opened this issue Jan 11, 2017 · 11 comments
Closed

MultiGrid alignment when scrolled to far-right or bottom #535

andrewdavey opened this issue Jan 11, 2017 · 11 comments
Labels

Comments

@andrewdavey
Copy link

I was trying out the MultiGrid demo at https://bvaughn.github.io/react-virtualized/#/components/MultiGrid and noticed a problem when scrolling to the far-right or bottom.

multi-grid-alignment

The columns in the top grid become misaligned with the main grid body. (Same for the rows when scrolling to bottom.)

I assume this is due to the presence of the scrollbar in one div causing an offset?

Tested in Chrome 55 and Firefox 50

@bvaughn bvaughn added the bug label Jan 12, 2017
@natew
Copy link

natew commented Jan 20, 2017

I noticed this as well, with a pretty wide table (10k items by 70px), it actually seems to distort more or less based on scroll:

image

Direction seems to affect it as well:

https://v.usetapes.com/Qg5Mlwx5Dr

@jeffvan576
Copy link

jeffvan576 commented Jan 23, 2017

Running into the same issue using ScrollSync
image

image

@bvaughn
Copy link
Owner

bvaughn commented Jan 23, 2017

Makes sense; MultiGrid uses ScrollSync internally, unfortunately.

@kachkaev
Copy link

kachkaev commented Feb 3, 2017

Has anyone been able to find a temporary workaround for this by a chance? It'd be great if you shared.

@jeffvan576
Copy link

jeffvan576 commented Feb 3, 2017

It's not pretty but it's a workaround:

https://gist.github.com/jeffvan576/dd6ad36869fff28be9043d9e28307135

Then feed in adjustedMeasurement.height and adjustedMeasurement.width instead of the AutoSizer width and height. Seems to be working here so far. Again, not pretty but a temporary patch.

@abhishiv
Copy link

Seems because of scrollbars. On chrome I can hide the scrollbars using this css

.grid-parent *::-webkit-scrollbar {
    width: 0px;
    height: 0px;
}

But for ff, I have to use @jeffvan576 solution. Would be nice to have it fixed in react-virtualized itself.

bvaughn pushed a commit that referenced this issue Mar 4, 2017
…eft Grids a little extra space to scroll into. (#535)
@bvaughn
Copy link
Owner

bvaughn commented Mar 4, 2017

Fixed this, although I'm not super thrilled with the fix. Check out 9.2.1 ...

@bvaughn bvaughn closed this as completed Mar 4, 2017
@neti123
Copy link

neti123 commented Oct 12, 2017

Still not fixed. To see it, put the cell border to black, not grey. With grey, it's hard to see. Scroll both with the scroll bar thumb and also with scroll bar end and start thumb. It's still not lined up perfectly, although very close.

@casvil
Copy link

casvil commented Jul 31, 2019

still not fixed

@SaliaLashgari
Copy link

Just to confirm, this still is not fixed and does not work...

barryjo added a commit to barryjo/react-tablist that referenced this issue Jul 19, 2020
@jeremysykes
Copy link

I know this issue was opened in 2017 and the issue is marked as closed, but this is still an ongoing issue. A fix for this would be greatly appreciated. thanks.

VV-YY added a commit to VV-YY/react-virtualized that referenced this issue Jan 18, 2023
gerald525 added a commit to gerald525/react-virtualized that referenced this issue Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants