Add onColumnClick to Table #1207
Conversation
|
I definitely could use this. There are some columns I need the ability to click and others I need to disable as they contain buttons in them |
| @@ -447,6 +454,10 @@ export default class Table extends React.PureComponent { | |||
| rowIndex, | |||
| }); | |||
|
|
|||
| const onClick = event => { | |||
| onColumnClick && onColumnClick({columnData, dataKey, event}); | |||
There was a problem hiding this comment.
I don't think its necessary to pass in the event. We should just invoke the callback with columnData and datakey
There was a problem hiding this comment.
Indeed, I am not using event in my handlers, but I added it to make it the same callback parameters as onHeaderClick
|
Can you also add unit tests? To make sure that column clicks invoke the callback with the right parameters? |
|
Tests are in |
|
@grahamlyus my b mustve miss the tests last night. |
|
Thanks for contributing! |
* bvaughn/master: (54 commits) Update version and changelog for 9.21.0 release (bvaughn#1252) chore: update lockfile Update ci badge (bvaughn#1227) Allow users to override default table row styles (bvaughn#1175) Add onColumnClick to Table (bvaughn#1207) remove unused variable in Masonry.example.js (bvaughn#1218) Fix Table aria attributes (bvaughn#1208) Fix typo in CellMeasurer.DynamicHeightTableColumn.example.js (bvaughn#1190) Update usingAutoSizer.md (bvaughn#1186) Add an extra check for an e.target.className.indexOf function (bvaughn#1210) Fix broken Slack badge image (bvaughn#1205) docs(CellMeasurer): fix `import` statement (bvaughn#1187) Added new friend (bvaughn#1197) Fix createMultiSort bug (bvaughn#1051) adding new usecase example and fix some typos (bvaughn#1168) Updating version to 9.20.1 Update changelog for the 9.20.1 release (bvaughn#1167) Prevent early debounceScrollEndedCallback when there is a slow render (bvaughn#1141) removing sideEffects (bvaughn#1163) fix for bvaughn#998 with test cases (bvaughn#1154) ...
|
columnData seems to always be undefined |
|
Wanted to follow up as well, |
|
@christianbalderrama @eubrunomiguel can you open an issue? Thanks! |
|
|
This change adds
onColumnClicktoTable, works the same way asonHeaderClick.I was attaching
onClickin myColumncellRenderer, but it doesn't work when the cell is empty. Attaching to thedivin_createColumnworks regardless.