Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #589: add public setter on ArrowKeyStepper to override scroll indexes #592

Conversation

alexandro81
Copy link

Add a public setter on ArrowKeyStepper in order to override the scroll indexes in its local state.
See issue #589 for details.

@alexandro81 alexandro81 changed the title Issue ##589: add public setter on ArrowKeyStepper to override scroll indexes Issue #589: add public setter on ArrowKeyStepper to override scroll indexes Feb 23, 2017
@bvaughn
Copy link
Owner

bvaughn commented Feb 24, 2017

Hey @alexandro81. Thanks for creating this PR! Looks great! I wonder if I could trouble you to also update the ArrowKeyStepper.md docs to list the new public method? (Like we do for List)

@alexandro81
Copy link
Author

Of course @bvaughn !
Done!

@bvaughn bvaughn merged commit daeb0b6 into bvaughn:master Feb 25, 2017
@bvaughn
Copy link
Owner

bvaughn commented Feb 25, 2017

Thanks! This has been merged, although I made one small tweak for compatibility with existing APIs. The new method uses named parameters- rather than setScrollIndexes(scrollToRow, scrollToColumn) it's setScrollIndexes({ scrollToColumn, scrollToRow })

This change will go out in minor release 9.1.0 momentarily and I'll link to your PR in the CHANGELOG 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants