Grid: Improve accessibility by adding props aria-readonly & role="rowgroup"
#744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is excellent! Thanks for improving accessibility! ❤️ I'm going to hold off on merging this until #743 has been merged since that PR is pretty complicated and I don't want to cause any conflicts. |
|
I've merged master into this branch and manually resolved conflicts |
|
This feature has been released in version 9.10.0. Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
aria-readonlyis set on the outer<div>withrole="grid"to indicate it contains elements which are operable but not editable (contra thegridrole default). It can be overridden. The default value istrue.role="rowgroup"is set on the inner container<div>to establish the relationship between the outer<div>withrole="grid"and children withrole="row". It helps assistive technologies identify the inner container as something akin to a<tbody>. It can be overridden. The default value is"rowgroup".Why did it change?
Together, these props allow JAWS to recognize
Gridas a table and enable “Table Layer” reading commands.