Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position offset computing for window #920

Merged
merged 18 commits into from
Dec 29, 2017
Merged

Conversation

TrySound
Copy link
Contributor

The case is visible when you scroll down 3000px, do small resize and scroll again. Viewport is cleaned. documentElement relativity is different.

@codecov-io
Copy link

codecov-io commented Dec 27, 2017

Codecov Report

Merging #920 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
+ Coverage    89.9%   89.93%   +0.03%     
==========================================
  Files          57       57              
  Lines        1615     1620       +5     
==========================================
+ Hits         1452     1457       +5     
  Misses        163      163
Impacted Files Coverage Δ
source/WindowScroller/utils/dimensions.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f275a57...f325619. Read the comment docs.

@TrySound
Copy link
Contributor Author

@bvaughn Tried to use puppeteer. There's a lot of boilerplate in installing and bootstrapping, but hope it can be resolved soon.

@TrySound
Copy link
Contributor Author

Don't know how to fix it. Without sandboxing the error looks like this

Error: Failed to launch chrome!
/home/circleci/project/node_modules/puppeteer/.local-chromium/linux-515411/chrome-linux/chrome: error while loading shared libraries: libXcomposite.so.1: cannot open shared object file: No such file or directory


TROUBLESHOOTING: https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md

    at onClose (/home/circleci/project/node_modules/puppeteer/lib/Launcher.js:211:14)
    at Interface.helper.addEventListener (/home/circleci/project/node_modules/puppeteer/lib/Launcher.js:200:50)
    at Interface.emit (events.js:164:20)
    at Interface.close (readline.js:381:8)
    at Socket.onend (readline.js:154:10)
    at Socket.emit (events.js:164:20)
    at endReadableNT (_stream_readable.js:1062:12)
    at process._tickCallback (internal/process/next_tick.js:152:19)

@TrySound
Copy link
Contributor Author

I asked in local slack. Guys say all is good in travis.

@TrySound
Copy link
Contributor Author

TrySound commented Dec 29, 2017

I'm gonna merge this and open PR with enabled e2e tests. Hope soon it will be merged :)

@TrySound TrySound merged commit 1936f5b into master Dec 29, 2017
@TrySound TrySound deleted the window-scroller-position-bug branch December 29, 2017 09:36
@TrySound TrySound mentioned this pull request Dec 29, 2017
@bvaughn
Copy link
Owner

bvaughn commented Dec 30, 2017

Hey Bogdan. Thanks for running with this. 😄

I've been spending time offline the past few days because I had family visiting from the East coast for the holidays. Happy to see you moved forward without being blocked.

@TrySound
Copy link
Contributor Author

Happy holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants