Make timing explicit in test

[eps1lon]

@bvaughn I found the test slightly confusing because the timing didn't appear in the test i.e. I could change the delay of flushPendingErrorsAndWarningsAfterDelay to 10s or 5s and it still passed.

I copied the approach of asyncAct to not flush recursively so that we can visualize the timing in the test.

In the end we traded one implementation detail (advance timers by 1 to flush commit) for another (advance timers by 1000 to flush pending warnings). I'd argue we're more interested in the 1000ms delay here and it isn't just an implementation detail.

Feel free to close this if you don't think this improves readability of the test.

Ideally we'd have a dedicated method to flush bridge operations so that we don't run unrelated timers. Running timers implicitly is, to me, more confusing then having to advance it explicitly.

[bvaughn]

Ideally we'd have a dedicated method to flush bridge operations so that we don't run unrelated timers. Running timers implicitly is, to me, more confusing then having to advance it explicitly.

Yeah. This sounds like it would be a nice improvement!

[bvaughn]

Sure. Lemme pull this into my branch. I was planning on adding another test ths morning anyway :D