Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Serde impls for kyber #2

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

OtaK
Copy link

@OtaK OtaK commented Jul 6, 2023

Hi!

Here's a small fix for the Serde impls regarding Kyber key material

@bwesterb
Copy link
Owner

bwesterb commented Jul 6, 2023

Thanks of this. What was the problem you hit?

@OtaK
Copy link
Author

OtaK commented Jul 6, 2023

Basically enabling the serde_impls feature flag wouldn't work as serde doesn't have blanket impls for large, fixed size arrays (it is pending on const generics in traits), hence the additional dependency.

And if you're storing the keys anyhow (encrypted at rest storage and/or for instance, storage of an MLS ratchet tree) you usually want to have a serde implementation to be able to serialize the data. That's when I hit the issue - and fixed it.

@bwesterb
Copy link
Owner

bwesterb commented Jul 7, 2023

Tested. Thanks!

@bwesterb bwesterb merged commit e5ffd22 into bwesterb:xyber768d00 Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants