Add sharding support #166
Merged
Add sharding support #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be merged into develop now. |
| Properties: handshakeProperties{runtime.GOOS, "Discordgo v" + VERSION, "", "", ""}, | ||
| LargeThreshold: 250, | ||
| Compress: s.Compress, | ||
| Shard: [2]int{s.ShardID, s.NumShards}, |
There was a problem hiding this comment.
It's fine to send [0,0] normally?
This implements the upcoming change (see discord/discord-api-docs#17) to add guild-sharding support directly in the Discord Gateways.
|
Merge time? |
|
Oh I missed binzy's comment I guess :) |
alex-j-butler
pushed a commit
to alex-j-butler/discordgo
that referenced
this pull request
Nov 5, 2016
Add sharding support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this until discord/discord-api-docs#17 is ready
This PR adds support for Discords new builtin sharding implementation, which allows users to segment guilds across multiple websocket connections.