Added handling of conversion of names #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxparks
reviewed
Jun 15, 2019
| # will not be accepted by `bq load` when it contains illegal characters. | ||
| # Characters such as #, / or -. Neither will it be accepted if the column name | ||
| # in the schema is larger than 128 characters. | ||
| self.sanitize_names = sanitize_names |
There was a problem hiding this comment.
Can you remove the trailing white space here?
bxparks
requested changes
Jun 15, 2019
| # Characters such as #, / or -. Neither will it be accepted if the column name | ||
| # in the schema is larger than 128 characters. | ||
| self.sanitize_names = sanitize_names | ||
|
|
There was a problem hiding this comment.
Here too, remove trailing white spaces..
| elif key == 'type' and value in ['QINTEGER', 'QFLOAT', 'QBOOLEAN']: | ||
| new_value = value[1:] | ||
| elif key == 'mode': | ||
| if infer_mode and value == 'NULLABLE' and filled: | ||
| new_value = 'REQUIRED' | ||
| else: | ||
| new_value = value | ||
| elif key == 'name' and sanitize_names: | ||
| print(value) |
There was a problem hiding this comment.
Remove debugging print() statement, will corrupt the schema output
tests/test_generate_schema.py
Outdated
| records = chunk['records'] | ||
| expected_errors = chunk['errors'] | ||
| expected_error_map = chunk['error_map'] | ||
| expected_schema = chunk['schema'] | ||
|
|
||
| print("Test chunk %s: First record: %s" % (chunk_count, records[0])) | ||
|
|
||
| print(sanitize_names) |
There was a problem hiding this comment.
Remove debugging print() statement
|
Hi again. It should look better now, let me know if there is anything else you think I should change. |
|
There is still one line that has a trailing space, but it's minor. I'll fix it after merging this, and I'll update the CHANGELOG and README. Thanks for the PR! |
|
Thank you, I really like the work you put in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when given a csv with incorrect column names
closes issue #14
#33