Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "mapSplitter" #22

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Implement "mapSplitter" #22

merged 2 commits into from
Jan 9, 2024

Conversation

eayus
Copy link
Contributor

@eayus eayus commented Jan 3, 2024

Implement #21

@byorgey
Copy link
Owner

byorgey commented Jan 5, 2024

Looks good to me, thanks! I think the CI is failing because the toLower in the doctest is not in scope. Adding >>> import Data.Char (toLower) to the doctest ought to fix it.

@eayus
Copy link
Contributor Author

eayus commented Jan 7, 2024

Oh whoops, hopefully that fixes the issue.

@byorgey
Copy link
Owner

byorgey commented Jan 9, 2024

Thanks!

@byorgey byorgey merged commit 815f1b3 into byorgey:master Jan 9, 2024
16 checks passed
@byorgey
Copy link
Owner

byorgey commented Jan 11, 2024

Released to Hackage as part of split-0.2.5.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 29, 2024
@depressed-pho
devel/hs-split: Update to 0.2.5
41ad10b 
* 0.2.5 (9 January 2024)

  - Test with GHC 9.8.
  - New function `mapSplitter` witnessing the fact that `Splitter` is
    a contravariant functor
    ([#22](byorgey/split#22), thanks to Ellis
    Kesterton)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eayus @byorgey