Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use linter rowserrcheck and sqlclosecheck and fix errors #1721

Closed
wants to merge 1 commit into from
Closed

chore: use linter rowserrcheck and sqlclosecheck and fix errors #1721

wants to merge 1 commit into from

Conversation

dragonly
Copy link
Contributor

@dragonly dragonly commented Jul 1, 2022

rowserrcheck checks whether sql.Rows.Err is correctly checked.
sqlclosecheck checks if SQL rows/statements are closed.

@dragonly dragonly requested a review from d-bytebase as a code owner July 1, 2022 10:11
@cla-bot cla-bot bot added the cla-signed label Jul 1, 2022
@dragonly dragonly changed the title use linter rowserrcheck and sqlclosecheck and fix errors. chore: use linter rowserrcheck and sqlclosecheck and fix errors Jul 1, 2022
d-bytebase
d-bytebase reviewed Jul 2, 2022
View reviewed changes
Copy link
Contributor

@d-bytebase d-bytebase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some tests failing. Maybe we can split the change to narrow down the cause. Thanks for adding the new checkers.

@dragonly
Copy link
Contributor Author

dragonly commented Jul 4, 2022

Maybe we can split the change to narrow down the cause.

SGTM. I'll split this PR into small groups and hope to catch and fix the error easier.

@dragonly dragonly marked this pull request as draft July 4, 2022 02:47
@RainbowDashy
Copy link
Contributor

I noticed that we are getting this error: error: conn busy. After some googling, I found this which might be helpful.

@dragonly dragonly mentioned this pull request Jul 4, 2022
Merged
@dragonly dragonly closed this Jul 4, 2022
@dragonly dragonly deleted the dragonly/chore/linter-sqlclosecheck branch July 4, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-bytebase d-bytebase d-bytebase left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragonly @RainbowDashy @d-bytebase