Fix tests on FreeBSD #341
Merged
Fix tests on FreeBSD #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable tests that are failing on FreeBSD. The "ambient" versions of these tests are also failing, so this appears to be platform-specific behavior rather than cap-std's behavior.
Change the `RESOLVE_BENEATH` check to check for the behavior of opening `..` on FreeBSD.
FreeBSD 14 supports the RESOLVE_BENEATH semantics where `..` is a capability error even when the base fd is the root directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD CI isn't currently running (#340), so fix some issues on FreeBSD that had gone unnoticed. Adjust the Cirrus CI scripts to use the existing
curlinstead of building a new one, adjust the tests for FreeBSD's behavior opening.on a directory without search permissions, adjust thebeneath_supportedtest to test for FreeBSD 14'sRESOLVE_BENEATHbehavior, and add FreeBSD 14.0-snap to the Cirrus CI config.