This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Fixes #716: Stub out parse_x86_cpuid in the non-x86 case #717

Merged

sunfishcode merged 1 commit into bytecodealliance:master from bnjbvr:stub-out-parse-x86-cpuid

Mar 28, 2019

Member

bnjbvr commented Mar 28, 2019

See #716 for discussion; an alternative solution is to add the dependency cfg-if and use cfg_if! here.


          Fixes bytecodealliance#716: Stub out parse_x86_cpuid in the non-x86 c…

199eaad

…ase;

bnjbvr requested a review from sunfishcode

March 28, 2019 11:43

Member

sunfishcode commented Mar 28, 2019

If cranelift-native starts having more places where cfg-if would be helpful, I think it'll make sense to use it, but this PR looks good for now.

sunfishcode merged commit d477dc4 into bytecodealliance:master

bnjbvr deleted the stub-out-parse-x86-cpuid branch

March 28, 2019 17:34

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet