Add crypto hmac sha 256 #685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code still need a change log entry, on top of any polished suggested during code review. |
saulecabrera
reviewed
Jul 2, 2024
|
The cargo vet failures are expected, since you're introducing new dependencies. We can resolve those once we're getting close to merging this one. |
HmacSha256::new_from_slice(&js_string_secret.as_bytes()) => HmacSha256::new_from_slice(js_string_secret.as_bytes()) No need to pass in address here. Same for js_string_message.
Also drop javy_ prefix in anticipation of switching to winter cg.
ewalk153
force-pushed
the
add-crypto-hmac-256
branch
from
077c10d
to
4e6f967
Compare
Ran `cargo fmt -- --check`, and applied suggestions, per ci feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Running crypto functions in Javascript quickly runs out of fuel, which rust is must more efficient at the job. This is a wrapper to expose the rust hmac-sha256 implementation to javy user code.
Why am I making this change?
To conserve fuel when running crypto. As a bonus, the crypto function is not left to end users to get right.
Checklist
javy-cliandjavy-coredo not require updating CHANGELOG files.