Disable reference-types since Wizer doesn't support them #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulecabrera
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
I was curious to know more about the concrete details of the change, for posterity and completeness here's a deeper explanation of of the inner workings of this change: WebAssembly/tool-conventions#233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Disabling reference types when compiling javy-core.
Why am I making this change?
The latest Rust stable compiler has started to emit instructions which rely on reference types support. Wizer (as of Wizer 7.0.0) does not support reference types. This causes the build for Javy CLI to fail when Wizer is executed on javy-core.
Checklist
javy-cliandjavy-coredo not require updating CHANGELOG files.