Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename javy-core to javy-plugin #797

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Renaming javy-core to javy-plugin.

I've updated the name in our documentation but I will go through the documentation more holistically in the future to ensure it's up-to-date as opposed to doing that as part of this PR. I have also tested the release GitHub Action to determine that it is working correctly with this change.

Why am I making this change?

Part of #768. The javy-core crate is the default plugin for Javy so a name like javy-plugin better reflects that.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- the test_core step in CI seems stuck, I think it's due to the name of the jobs?

@jeffcharles
Copy link
Collaborator Author

It's because the test_core check is marked as mandatory but the name of the workflow has been changed to test_plugin. So I need to remove test_core as a mandatory check before I can merge and then I can mark test_plugin as mandatory.

@jeffcharles jeffcharles merged commit 2037ce1 into main Nov 1, 2024
7 checks passed
@jeffcharles jeffcharles deleted the jc.rename-core-to-plugin branch November 1, 2024 14:42
@jeffcharles
Copy link
Collaborator Author

Branch protection rules have been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants