Remove the OperandConstraint::Stack variant #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the Requirement::Stack case, as there is no longer a constraint that can produce it. Co-authored-by: Nick Fitzgerald <[email protected]>
elliottt
force-pushed
the
trevor/remove-stack-constraints
branch
from
ef52ef4
to
aa994ad
Compare
cfallin
approved these changes
Aug 30, 2024
| ) { | ||
| debug_assert!(spill_weight <= BUNDLE_MAX_SPILL_WEIGHT); | ||
| self.spill_weight_and_props = spill_weight | ||
| | (if minimal { 1 << 31 } else { 0 }) | ||
| | (if fixed { 1 << 30 } else { 0 }) | ||
| | (if fixed_def { 1 << 29 } else { 0 }) | ||
| | (if stack { 1 << 28 } else { 0 }); | ||
| | (if fixed_def { 1 << 29 } else { 0 }); |
There was a problem hiding this comment.
Since we get bit 28 back here can we update BUNDLE_MAX_SPILL_WEIGHT as well (so the saturation point moves a little further out, leading to maybe slightly better alloc in deeply nested loops)?
elliottt
added a commit
that referenced
this pull request
Sep 11, 2024
Fix a fuzzbug introduced in #185 where we missed updating a mask after also updating a constant indicating that the bit was no longer used. This PR fixes the bug by using the appropriate constant when masking, and also removing some additional functions that were missed in #185. co-authored-by: Chris Fallin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the removal of safepoints, remove the
OperandConstraint::StackandRequirement::Stackenum variants, as there's no longer any way to construct them.Co-authored-by: Nick Fitzgerald [email protected]