Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect statx support properly in Docker #352

Closed
sunfishcode opened this issue Jun 3, 2022 · 0 comments · Fixed by #357
Closed

Detect statx support properly in Docker #352

sunfishcode opened this issue Jun 3, 2022 · 0 comments · Fixed by #357

Comments

@sunfishcode
Copy link
Member

Std uses a special check for detecting whether ``statxis available. To support running in Docker, rustix should do a similar check when it usesstatx`.
@sunfishcode sunfishcode mentioned this issue Jun 3, 2022
Merged
sunfishcode added a commit that referenced this issue Jun 6, 2022
@sunfishcode
Detect when statx isn't available on older versions of Docker.
c4807ec 
In older versions of Docker, `statx` can fail with `EPERM` meaning it
isn't available. Recognize this, and translate it into `ENOSYS`. Also,
have `statx` remember this and fail quickly in future calls.

This is more emulation than rustix usually likes to do, but in this
case, this is the behavior seems likely to be what most users will
want, and we might as well put the code in one place.

Fixes #352.
@sunfishcode sunfishcode mentioned this issue Jun 6, 2022
Merged
sunfishcode added a commit that referenced this issue Jun 6, 2022
@sunfishcode
Detect when statx isn't available on older versions of Docker.
45b8895 
In older versions of Docker, `statx` can fail with `EPERM` meaning it
isn't available. Recognize this, and translate it into `ENOSYS`. Also,
have `statx` remember this and fail quickly in future calls.

This is more emulation than rustix usually likes to do, but in this
case, this is the behavior seems likely to be what most users will
want, and we might as well put the code in one place.

Fixes #352.
sunfishcode added a commit that referenced this issue Jun 7, 2022
@sunfishcode
Detect when statx isn't available on older versions of Docker.
5687ca2 
In older versions of Docker, `statx` can fail with `EPERM` meaning it
isn't available. Recognize this, and translate it into `ENOSYS`. Also,
have `statx` remember this and fail quickly in future calls.

This is more emulation than rustix usually likes to do, but in this
case, this is the behavior seems likely to be what most users will
want, and we might as well put the code in one place.

Fixes #352.
sunfishcode added a commit that referenced this issue Jun 13, 2022
@sunfishcode
Detect when statx isn't available on older versions of Docker.
8994c30 
In older versions of Docker, `statx` can fail with `EPERM` meaning it
isn't available. Recognize this, and translate it into `ENOSYS`. Also,
have `statx` remember this and fail quickly in future calls.

This is more emulation than rustix usually likes to do, but in this
case, this is the behavior seems likely to be what most users will
want, and we might as well put the code in one place.

Fixes #352.
@SUPERCILEX SUPERCILEX mentioned this issue Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect when statx isn't available on older versions of Docker. bytecodealliance/rustix
1 participant
@sunfishcode