Fix the default binary format for most architectures to be ELF. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the [logic in LLVM], make the binary format for most targets be ELF instead of Unknown. To preserve round-tripping for Rust target names, this requires some special-casing in the formatting code, but this isn't new; a lot of targets require special cases to round-trip properly. [logic in LLVM]: https://github.com/llvm/llvm-project/blob/d3e7c4ce7a3d7f08cea02cba8f34c590a349688b/llvm/lib/TargetParser/Triple.cpp#L877
|
This is now released in target-lexicon 0.12.15. |
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the logic in LLVM, make the binary format for most targets be ELF instead of Unknown. To preserve round-tripping for Rust target names, this requires some special-casing in the formatting code, but this isn't new; a lot of targets require special cases to round-trip properly.