Add support for some new WASI targets: #99
Conversation
|
Gentle ping. rust-lang/miri#722 (comment) needs this to compile cg_clif for wasm32-wasi-preview1-threads. |
|
Following this discussion, we should change these names to |
* `wasm32-wasip1` * `wasm32-wasip2` * `wasm32-wasip1-threads`
alexcrichton
force-pushed
the
wasi-targets
branch
from
085ade0
to
c96375b
Compare
|
Oops yes, updated now! |
|
This is now released in target-lexicon 0.12.14. |
| @@ -1685,6 +1694,9 @@ mod tests { | |||
| "wasm32-unknown-emscripten", | |||
| "wasm32-unknown-unknown", | |||
| "wasm32-wasi", | |||
| "wasm32-wasip1-threads", | |||
There was a problem hiding this comment.
wasm32-wasi-preview1-threads hasn't been renamed to wasm32-wasip1-threads yet and there is no open PR for this either.
There was a problem hiding this comment.
Indeed! I was a bit forward thinking adding this in, so I suspect it won't be used for a bit.
There was a problem hiding this comment.
I specifically need support for the exact target triple for wasi with threads for rust-lang/miri#722 (comment) to compile successfully. target-lexicon refuses to compile for any target which it doesn't know how to parse even if said target will never be used at runtime as compilation target.
There was a problem hiding this comment.
Once the wasip{1,2} targets land in rustc I'll post a follow-up to rename preview1-threads to p1-threads, but in the meantime it seems reasonable to add the target here too
wasm32-wasip1wasm32-wasip2wasm32-wasip1-threads