Skip to content

Commit

Permalink
Relax wasi memory export check when wasi-threads is enabled (#1893)
Browse files Browse the repository at this point in the history
  • Loading branch information
yamt authored Jan 16, 2023
1 parent 903f521 commit 5f0f8fe
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion core/iwasm/interpreter/wasm_loader.c
Original file line number Diff line number Diff line change
Expand Up @@ -4185,7 +4185,20 @@ check_wasi_abi_compatibility(const WASMModule *module,

memory = wasm_loader_find_export(module, "", "memory", EXPORT_KIND_MEMORY,
error_buf, error_buf_size);
if (!memory) {
if (!memory
#if WASM_ENABLE_LIB_WASI_THREADS != 0
/*
* with wasi-threads, it's still an open question if a memory
* should be exported.
*
* https://github.com/WebAssembly/wasi-threads/issues/22
* https://github.com/WebAssembly/WASI/issues/502
*
* Note: this code assumes the number of memories is at most 1.
*/
&& module->import_memory_count == 0
#endif
) {
set_error_buf(error_buf, error_buf_size,
"a module with WASI apis must export memory by default");
return false;
Expand Down

0 comments on commit 5f0f8fe

Please sign in to comment.