-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a placeholder for WASI threads implementation #1783
Create a placeholder for WASI threads implementation #1783
Conversation
9574bd4
to
3becdff
Compare
i feel the original version is simple enough. |
@yamt it is indeed, but it's also a bit incorrect, and I'm not happy about the quality of that at all - I only made a PR to save my work and give others opportunity to provide higher-level feedback; I actually never intended to merge it as-it-is. As I came back to that work, I thought I'd use it as opportunity to split it into two separate PRs, where the first one is just to provide a template, and the second will be about the actual implementation (with some TODOs, which we address later on - that's why the development will happen on the |
3becdff
to
6933505
Compare
6933505
to
41959d6
Compare
41959d6
to
4ce516e
Compare
4ce516e
to
478920c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e#1783) This a simpler version of the PR: bytecodealliance#1638
…e#1783) This a simpler version of the PR: bytecodealliance#1638
This a simpler version of the PR: #1638
To simplify the review, I'll split it into a few smaller changes, starting from this one, which just creates a function stub and a simplistic example.