Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert pr#3194 modification #3199

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Revert pr#3194 modification #3199

merged 1 commit into from
Mar 5, 2024

Conversation

lum1n0us
Copy link
Collaborator

@lum1n0us lum1n0us commented Mar 4, 2024

  • address values in call stack dump are relative to file beginning
  • if running under fast-interp mode, address values are relative to every pre-compiled function beginning. not compatible with addr2line

@lum1n0us lum1n0us mentioned this pull request Mar 4, 2024
Closed
@wenyongh
Copy link
Contributor

wenyongh commented Mar 4, 2024

@eloparco could you help check whether this PR is good to you? Thanks.

eloparco
eloparco reviewed Mar 4, 2024
View reviewed changes
test-tools/addr2line/addr2line.py Outdated
+ " - the wasm file is compiled with debug info. (like: clang -g) \n"
+ " - the call-stack dump is generated by iwasm\n"
+ " - iwasm is compiled with -DWAMR_BUILD_DUMP_CALL_STACK=1\n"
+ " - iwasm isn't running under fast-interp mode. -DWAMR_FAST_INTERP=0\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ " - iwasm isn't running under fast-interp mode. -DWAMR_FAST_INTERP=0\n"
+ " - iwasm isn't running under fast-interp mode. -DWAMR_BUILD_FAST_INTERP=0\n"

@eloparco
Copy link
Contributor

eloparco commented Mar 4, 2024

@eloparco could you help check whether this PR is good to you?

Tried it and it works! I was using fast interpreter mode, switching to to classic interpreter fixed it.

eloparco
eloparco approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@eloparco eloparco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment on a typo

@lum1n0us
Revert pr#3194.
1599e7d 
- address values in call stack dump are relative to file beginning
- if running under fast-interp mode, address values are relative to
  every pre-compiled function beginning. not compabible with addr2line
@wenyongh wenyongh merged commit d555c16 into bytecodealliance:main Mar 5, 2024
1 check passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 1, 2024
@lum1n0us @victoryang00
Revert PR bytecodealliance#3194 (bytecodealliance#3199)
aca32e4 
- Address values in call stack dump are relative to file beginning
- If running under fast-interp mode, address values are relative to
  every pre-compiled function beginning, which is not compatible
  with addr2line
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 2, 2024
@lum1n0us @victoryang00
Revert PR bytecodealliance#3194 (bytecodealliance#3199)
3f6f3c5 
- Address values in call stack dump are relative to file beginning
- If running under fast-interp mode, address values are relative to
  every pre-compiled function beginning, which is not compatible
  with addr2line

Signed-off-by: victoryang00 <[email protected]>
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@lum1n0us
Revert PR bytecodealliance#3194 (bytecodealliance#3199)
232340d 
- Address values in call stack dump are relative to file beginning
- If running under fast-interp mode, address values are relative to
  every pre-compiled function beginning, which is not compatible
  with addr2line
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@lum1n0us @victoryang00
Revert PR bytecodealliance#3194 (bytecodealliance#3199)
7a59de5 
- Address values in call stack dump are relative to file beginning
- If running under fast-interp mode, address values are relative to
  every pre-compiled function beginning, which is not compatible
  with addr2line

Signed-off-by: victoryang00 <[email protected]>
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@lum1n0us @victoryang00
Revert PR bytecodealliance#3194 (bytecodealliance#3199)
88caeaa 
- Address values in call stack dump are relative to file beginning
- If running under fast-interp mode, address values are relative to
  every pre-compiled function beginning, which is not compatible
  with addr2line

Signed-off-by: victoryang00 <[email protected]>
@lum1n0us lum1n0us deleted the fix/revert_add2line_issue branch May 31, 2024 03:19
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request Jun 7, 2024
@lum1n0us @victoryang00
Revert PR bytecodealliance#3194 (bytecodealliance#3199)
71cb447 
- Address values in call stack dump are relative to file beginning
- If running under fast-interp mode, address values are relative to
  every pre-compiled function beginning, which is not compatible
  with addr2line

Signed-off-by: victoryang00 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh approved these changes

@eloparco eloparco eloparco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lum1n0us @wenyongh @eloparco