-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct function index during translation #3232
Merged
wenyongh
merged 1 commit into
bytecodealliance:main
from
lum1n0us:fix/correct_function_index
Mar 18, 2024
Merged
Correct function index during translation #3232
wenyongh
merged 1 commit into
bytecodealliance:main
from
lum1n0us:fix/correct_function_index
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@johnlanni please take a look and give it a try |
johnlanni
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing is fine
wenyongh
reviewed
Mar 15, 2024
N from "aot_func#N" adds import function count is the correct wasm function index
lum1n0us
force-pushed
the
fix/correct_function_index
branch
from
March 18, 2024 00:59
e02479f
to
3e88845
Compare
wenyongh
approved these changes
Mar 18, 2024
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 1, 2024
…ytecodealliance#3232) Adding the N from "aot_func#N" with the import function count is the correct wasm function index.
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 2, 2024
…ytecodealliance#3232) Adding the N from "aot_func#N" with the import function count is the correct wasm function index. Signed-off-by: victoryang00 <[email protected]>
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ytecodealliance#3232) Adding the N from "aot_func#N" with the import function count is the correct wasm function index.
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ytecodealliance#3232) Adding the N from "aot_func#N" with the import function count is the correct wasm function index. Signed-off-by: victoryang00 <[email protected]>
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ytecodealliance#3232) Adding the N from "aot_func#N" with the import function count is the correct wasm function index. Signed-off-by: victoryang00 <[email protected]>
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
Jun 7, 2024
…ytecodealliance#3232) Adding the N from "aot_func#N" with the import function count is the correct wasm function index. Signed-off-by: victoryang00 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N from "aot_func#N" adds import function count is the correct wasm function index