Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct function index during translation #3232

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

lum1n0us
Copy link
Collaborator

N from "aot_func#N" adds import function count is the correct wasm function index

@lum1n0us
Copy link
Collaborator Author

@johnlanni please take a look and give it a try

Copy link

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing is fine

doc/perf_tune.md Outdated Show resolved Hide resolved
doc/perf_tune.md Outdated Show resolved Hide resolved
doc/perf_tune.md Outdated Show resolved Hide resolved
N from "aot_func#N" adds import function count is the correct wasm
function index
@wenyongh wenyongh merged commit 8c1269d into bytecodealliance:main Mar 18, 2024
1 check passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 1, 2024
…ytecodealliance#3232)

Adding the N from "aot_func#N" with the import function count is the correct
wasm function index.
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 2, 2024
…ytecodealliance#3232)

Adding the N from "aot_func#N" with the import function count is the correct
wasm function index.

Signed-off-by: victoryang00 <[email protected]>
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…ytecodealliance#3232)

Adding the N from "aot_func#N" with the import function count is the correct
wasm function index.
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…ytecodealliance#3232)

Adding the N from "aot_func#N" with the import function count is the correct
wasm function index.

Signed-off-by: victoryang00 <[email protected]>
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…ytecodealliance#3232)

Adding the N from "aot_func#N" with the import function count is the correct
wasm function index.

Signed-off-by: victoryang00 <[email protected]>
@lum1n0us lum1n0us deleted the fix/correct_function_index branch May 31, 2024 03:19
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request Jun 7, 2024
…ytecodealliance#3232)

Adding the N from "aot_func#N" with the import function count is the correct
wasm function index.

Signed-off-by: victoryang00 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants