Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit test suites for WAMR. #3490

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Conversation

yzha107
Copy link
Contributor

@yzha107 yzha107 commented May 31, 2024

No description provided.

@@ -1,51 +1,52 @@
# Copyright (C) 2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
# Copyright (C) 2019 Intel Corporation. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe don't modify existing license header

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a new CMakeLists.txt from our internal repo, the original CMakeLists.txt was moved to tests/unit/tid-allocator/CMakeLists.txt.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks

@loganek
Copy link
Collaborator

loganek commented Jun 3, 2024

I'm really glad to see the unit tests being open-sourced, hopefully that'll streamline the release process. Just one comment though - is there any plan to run unit tests as part of the CI?

@wenyongh wenyongh merged commit 380cd7b into bytecodealliance:main Jun 4, 2024
1 check passed
@wenyongh
Copy link
Contributor

wenyongh commented Jun 4, 2024

I'm really glad to see the unit tests being open-sourced, hopefully that'll streamline the release process. Just one comment though - is there any plan to run unit tests as part of the CI?

Yes, we are considering to add it to CI and will discuss internally firstly - maybe add it for both PR creating and nightly run, maybe only for nightly run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants