Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasmtime_config_wasm_multi_memory_set is missing from the C API #3066

Closed
peterhuene opened this issue Jul 7, 2021 · 1 comment · Fixed by #3071
Closed

wasmtime_config_wasm_multi_memory_set is missing from the C API #3066

peterhuene opened this issue Jul 7, 2021 · 1 comment · Fixed by #3071
Assignees
@peterhuene
Labels
bug Incorrect behavior in the current implementation that needs fixing enhancement wasmtime:c-api Issues pertaining to the C API.

Comments

@peterhuene
Copy link
Member

It appears that wasmtime_config_wasm_multi_memory_set is missing from the C API and therefore all the non-Rust language embeddings.

This means that the other language embeddings can't enable multi-memory.
@peterhuene peterhuene added bug Incorrect behavior in the current implementation that needs fixing enhancement wasmtime:c-api Issues pertaining to the C API. labels Jul 7, 2021
@github-actions
Copy link

github-actions bot commented Jul 7, 2021

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@peterhuene peterhuene changed the title wasmtime_config_wasm_multi_memory_set is missing wasmtime_config_wasm_multi_memory_set is missing from the C API Jul 7, 2021
@peterhuene peterhuene self-assigned this Jul 7, 2021
peterhuene added a commit to peterhuene/wasmtime that referenced this issue Jul 8, 2021
@peterhuene
Add setter for enabling multi-memory to the C API.
08575a8 
This commit adds `wasmtime_config_wasm_multi_memory_set` to the C API.

Fixes bytecodealliance#3066.
This was referenced Jul 8, 2021
Merged
Closed
Closed
@mykmartin mykmartin mentioned this issue Jul 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhuene peterhuene

Labels
bug Incorrect behavior in the current implementation that needs fixing enhancement wasmtime:c-api Issues pertaining to the C API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add setter for enabling multi-memory to the C API. peterhuene/wasmtime
1 participant
@peterhuene