Re-add Cranelift publish script #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Thanks! Two questions motivated by looking at the previous release script we had on Cranelift's repository, but nothing that should block landing!
- Do we have something that will bump the version numbers automatically in Cranelift's Cargo.toml files?
- The previous script indicated how to do the tag and push it to the repository, so each release has a corresponding tag, is this something that's still documented somewhere in one of the Wasmtime files?
fitzgen
force-pushed
the
cranelift-publish-script
branch
from
6f05368
to
612b806
Compare
|
Good eye on the typos! I also made it so that the scripts echo how to tag the release.
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.