Fix ImmLogic.invert(), and with it, fcopysign and float_misc test.
#1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cranelift
Subscribe to Label Actioncc @bnjbvr
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
jgouly
reviewed
Apr 23, 2020
jgouly
reviewed
Apr 23, 2020
bnjbvr
approved these changes
Apr 23, 2020
cfallin
force-pushed
the
aarch64-fcopysign
branch
from
c0df46a
to
d8ee798
Compare
Previously, `fcopysign` was mysteriously failing to pass the `float_misc` spec test. This was tracked down to bad logical-immediate masks used to separate the sign and not-sign bits. In particular, the masks for the and-not operations were wrong. The `invert()` function on an `ImmLogic` immediate, it turns out, assumed every immediate would be used by a 64-bit instruction; `ImmLogic` immediates are subtly different for 32-bit instructions. This change tracks the instruction size (32 or 64 bits) intended for use with each such immediate, and passes it back into `maybe_from_u64` when computing the inverted immediate. Addresses several of the failures (`float_misc`, `f32_bitwise`) for bytecodealliance#1521 (test failures) and presumably helps bytecodealliance#1519 (SpiderMonkey integration).
cfallin
force-pushed
the
aarch64-fcopysign
branch
from
d8ee798
to
8f462db
Compare
|
Updated with both of @jgouly's suggestions -- will merge once green. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
fcopysignwas mysteriously failing to pass thefloat_miscspec test. This was tracked down to bad logical-immediatemasks used to separate the sign and not-sign bits. In particular, the
masks for the and-not operations were wrong. The
invert()function onan
ImmLogicimmediate, it turns out, assumed every immediate would beused by a 64-bit instruction;
ImmLogicimmediates are subtly differentfor 32-bit instructions. This change tracks the instruction size (32 or
64 bits) intended for use with each such immediate, and passes it back
into
maybe_from_u64when computing the inverted immediate.Addresses one of the failures (
float_misc) for #1521 (test failures)and presumably helps #1519 (SpiderMonkey integration).