Re-enable the spec::simd::simd_align test for AArch64 #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the CI system really, really doesn't want you to enable this test, and is getting creative about it: I'll kick it for a rerun; I wonder if it's an actual issue with that crate or just some problem with our build env... |
|
Oh that's an issue with nightly Rust (sorry!), trying to fix that over in #1873 |
Copyright (c) 2020, Arm Limited.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jun 18, 2020
This commit disables the usage of "static" memory on CI and instead forces all memories to be "dynamic" meaning that they reserve much smaller chunks of memory. This causes the QEMU process's memory to drastically drop (10GiB -> 600MiB) and should allow us to keep enabling tests without hitting the OOM killer on CI. Closes bytecodealliance#1871 (includes that) Closes bytecodealliance#1893
alexcrichton
added a commit
that referenced
this pull request
Jun 18, 2020
* Enable the spec::simd::simd_align test for AArch64 Copyright (c) 2020, Arm Limited. * Disable static memory under QEMU on CI This commit disables the usage of "static" memory on CI and instead forces all memories to be "dynamic" meaning that they reserve much smaller chunks of memory. This causes the QEMU process's memory to drastically drop (10GiB -> 600MiB) and should allow us to keep enabling tests without hitting the OOM killer on CI. Closes #1871 (includes that) Closes #1893 * Fix typo Co-authored-by: Anton Kirilov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was previously enabled by PR #1802, which was failing in CI for unclear reasons and was subsequently merged without enabling any tests to unblock further work. However, the same PR enabled another test as well, so now we just isolate
spec::simd::simd_alignin a small change to check if it is problematic or not.