Support reference types in Func::wrap
#1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
changed the title
Func::wrapFunc::wrap
github-actions
bot
added
the
wasmtime:api
alexcrichton
reviewed
Jul 7, 2020
There was a problem hiding this comment.
Nice! This all looks pretty good to me, but I think that we still need to do checks for cross-store-ness and bad results there.
I think that we're guaranteed that the arguments will come from the same store (since they come from compiled code), but when the closure returns a value we need to guarantee that the return value comes from the same store as the function iteslf.
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
force-pushed
the
func-wrap-and-ref-types
branch
from
18b1fdc
to
2185c7f
Compare
|
Cross-store checks added, as well as tests for that, and documentation for the newly supported types. |
alexcrichton
approved these changes
Jul 7, 2020
fitzgen
force-pushed
the
func-wrap-and-ref-types
branch
from
2185c7f
to
62655cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.