Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport simd fixes to 0.38.0 #4334

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Backport simd fixes to 0.38.0 #4334

merged 2 commits into from
Jun 27, 2022

Commits on Jun 27, 2022

  1. x64: Fix codegen for the i8x16.swizzle instruction (bytecodeallianc… 

    …e#4318)

This commit fixes a mistake in the `Swizzle` opcode implementation in
the x64 backend of Cranelift. Previously an input register was casted to
a writable register and then modified, which I believe instructions are
not supposed to do. This was discovered as part of my investigation
into bytecodealliance#4315.
    @alexcrichton
    alexcrichton committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    845a6b8 View commit details
    Browse the repository at this point in the history

  2. x64: Fix codegen for the select instruction with v128 (bytecodealli… 

    …ance#4317)

This commit fixes a bug in the previous codegen for the `select`
instruction when the operations of the `select` were of the `v128` type.
Previously teh `XmmCmove` instruction only stored an `OperandSize` of 32
or 64 for a 64 or 32-bit move, but this was also used for these 128-bit
types which meant that when used the wrong move instruction was
generated. The fix applied here is to store the whole `Type` being moved
so the 128-bit variant can be selected as well.
    @alexcrichton
    alexcrichton committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    820ea2e View commit details
    Browse the repository at this point in the history