Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building for x86_64-linux-android #7055

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

truboxl
Copy link
Contributor

@truboxl truboxl commented Sep 18, 2023

Hi, these set of patches allow building for target x86_64-linux-android.

armv7-linux-androideabi and i686-linux-android are blocked by mitsuhiko/listenfd#16.
There maybe other roadblocks ahead but I wont investigate further for now.

@truboxl truboxl requested a review from a team as a code owner September 18, 2023 08:45
@truboxl truboxl requested review from alexcrichton and removed request for a team September 18, 2023 08:45
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Sep 18, 2023
Merged via the queue into bytecodealliance:main with commit ca702da Sep 18, 2023
18 checks passed
@truboxl truboxl deleted the x86_64-linux-android branch September 18, 2023 14:55
@cfallin
Copy link
Member

cfallin commented Sep 18, 2023

armv7-linux-androideabi and i686-linux-android are blocked by mitsuhiko/listenfd#16.
There maybe other roadblocks ahead but I wont investigate further for now.

A note for future: after resolving that issue, you'll also hit the (fairly fundamental) problem that Wasmtime doesn't support arm32 or x86-32 yet :-) We have issues on file for both (arm32: #1173, x86-32: #1980).

eduardomourar pushed a commit to eduardomourar/wasmtime that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants