Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream wasm-wave instances in wasmtime #8872

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Upstream wasm-wave instances in wasmtime #8872

wants to merge 4 commits into from
+780 −25

Commits on Jun 25, 2024

  1. wasmtime::component::Func: add a ty(&self, store) -> ComponentFunc … 

    …getter

analog of wasmtime::Func::ty, this gets a representation of the function's type
which itself doesnt require a &mut store passed to the params/results getters.

by rewriting Func::params and Func::results in terms of this new common
getter, I could eliminate the Arc<ComponentTypes> element in the Func struct.
    @pchickey
    pchickey committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5918a4b View commit details
    Browse the repository at this point in the history

  2. wasmtime: add wasm-wave instances behind an off-by-default wave fea… 

    …ture
    @pchickey
    pchickey committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    04a9c15 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @pchickey
    pchickey committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b6fd2ab View commit details
    Browse the repository at this point in the history

  4. vet imports, and trust wasm-wave because published by wasmtime-publish

    @pchickey
    pchickey committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7495d18 View commit details
    Browse the repository at this point in the history