Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MessageReplaceRender #47

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Add MessageReplaceRender #47

merged 2 commits into from
Sep 2, 2022

Conversation

chncaesar
Copy link
Contributor

@chncaesar chncaesar commented Aug 10, 2022

Changes in this PR.

需求 的外置插件。负责匹配正则并替换错误消息。

测试和描述参考 PR

UT Result

image

Copy link
Contributor

@allwefantasy allwefantasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要有个 .repo 目录,里面带上一些模板信息,参考其他插件项目。


val render = new ExceptionReplaceRender
val e = new RuntimeException("MLSQL Parser error in [line 1 column 2]")
assert(render.is_match(e))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里加一个format之后 matchExp 确保是清空状态的case吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Add ExceptionReplaceRender

Add MessageReplaceRender

Add MessageReplaceRender
@chncaesar chncaesar merged commit 4ff91b5 into byzer-org:master Sep 2, 2022
@chncaesar chncaesar deleted the zjc branch August 24, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants