Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend examples #11

Merged
merged 42 commits into from
Nov 5, 2022
Merged

Conversation

diarmidmackenzie
Copy link
Member

@diarmidmackenzie diarmidmackenzie commented Oct 31, 2022

This PR covers:

  • breaking out examples into 3 sets, covering Cannon local, Cannon worker & Ammo
  • creating equivalent Ammo examples for each Cannon example
  • as part of this, implementing Ammo equivalents of the utility compenents used in examples: force-pushable, grab, rain-of-entities.
  • enhancement to Ammo driver to support configuration of restitution on bodies.
  • enhancement to Ammo driver to support spring constraints
  • fixing VR grabbing for both Cannon and Ammo examples
  • major rework of docs: break Cannon-specific info into separate CannonDriver.md and make top-level doc even-handed regarding Ammo & Cannon
  • document warnings about Cannon Worker having lots of bugs at the moment
  • include mention of new C-Frame physx repo, and presentation of physx as an alternative to aframe-physics-system, including some pros & cons

Work on this PR has also uncovered a few issues that it has not resolved - these have been raised separately for future investigation. See issues #7, #8, #9, #10

If you want to see a live staged version of all the changes, ahead of this being merged, you can see that here:
https://diarmidmackenzie.github.io/aframe-physics-system/

README.md Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
@kylebakerio
Copy link
Member

throwing this link here, instead of just code comments, so that github hooks it in to that conversation for google and such: n5ro#171

Copy link
Member

@kylebakerio kylebakerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review just on initial read through, haven't tried examples yet.

dist/aframe-physics-system.js Show resolved Hide resolved
examples/ammo/materials.html Outdated Show resolved Hide resolved
examples/components/rain-of-entities.js Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
CannonDriver.md Outdated Show resolved Hide resolved
@kylebakerio
Copy link
Member

Love the examples, great work.

I get no reticle on the contraints for ammo page, the way I do on constraints for cannon. Are you aware of that and chose not to do it, or is it an error or oversight? Not a reason to deny the pull request, but nice to have if you were intending it.

@kylebakerio
Copy link
Member

Would also be nice if the examples were separated under 'cannon' and 'ammo' categories.

I also feel like the 'attached to cone' in the initial examples for both is pretty awkward... just makes a bad first impression and looks broken. Not saying you should rework that (happy to have it if you are willing), but we should probably do that. Not sure what we should take away from that, but seems like just flipping the cone upside down and having cube on the flat side would be cleaner?

Am I alone in thinking this?

grab now relies on physics colliders.
@diarmidmackenzie
Copy link
Member Author

Would also be nice if the examples were separated under 'cannon' and 'ammo' categories.

Did you look at this page?

https://diarmidmackenzie.github.io/aframe-physics-system/examples/

I've realized that this page...
https://diarmidmackenzie.github.io/aframe-physics-system/examples/

... has a link to the non-updated examples here:
https://c-frame.github.io/aframe-physics-system/examples/

So maybe that caused some confusion?

@diarmidmackenzie
Copy link
Member Author

I get no reticle on the contraints for ammo page

https://diarmidmackenzie.github.io/aframe-physics-system/examples/ammo/constraints.html

(see prev. comment, maybe you ended up one one of the non-updated pages due to incorrect absolute link)

@diarmidmackenzie
Copy link
Member Author

I also feel like the 'attached to cone' in the initial examples for both is pretty awkward...

Yes, agreed. I'll try to do something to improve this.

@diarmidmackenzie
Copy link
Member Author

I also feel like the 'attached to cone' in the initial examples for both is pretty awkward...

Yes, agreed. I'll try to do something to improve this.

Just moving the cone 1m to the left so the 2 objects are near to each other but don't intersect or z-fight makes this look a lot better IMO. I still don't love the example, but I'd rather work on new, better examples, than invest in this one any further...

@kylebakerio
Copy link
Member

I'm sure the incorrect links were the issue.

Going to the ammo example now, I get a reticle, but I get broken examples.

image

...then, after pasting this image and being here, and flipping back to the tab in question, suddenly the example are now working.

image

Interesting. My internet is very slow here today, so that is probably the cause, figured I'll post anyways since it's interesting that that's possible.

@kylebakerio
Copy link
Member

Is there anything left pending before this is ready for merge?

@kylebakerio
Copy link
Member

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants