Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving signal overlapping error message #137

Merged
merged 3 commits into from
Apr 28, 2024

Conversation

c4deszes
Copy link
Owner

Brief

  • The current error when signals overlap doesn't include much information on which signals overlap and in which frame
  • The new version includes the frame name and the signals which overlap

Checklist

  • Add relevant labels to the Pull Request
  • Review test results and code coverage
    • Review snapshot test results for deviations
  • Review code changes
    • Create relevant test scenarios
    • Update examples
    • Update JSON schema
  • Update documentation
    • Update examples in README
  • Update changelog
  • Update version number

Resolves

Evidence

  • Only tested manually and through regression

@c4deszes c4deszes added enhancement New feature or request ldf/frames Related to LIN frames labels Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (8a38dc2) to head (8d5c32a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          13       13           
  Lines        1465     1467    +2     
=======================================
+ Hits         1411     1413    +2     
  Misses         54       54           
Flag Coverage Δ
3.10 96.31% <100.00%> (+<0.01%) ⬆️
3.11 96.31% <100.00%> (+<0.01%) ⬆️
3.12 96.31% <100.00%> (+<0.01%) ⬆️
3.6 96.31% <100.00%> (+<0.01%) ⬆️
3.7 96.31% <100.00%> (+<0.01%) ⬆️
3.8 96.31% <100.00%> (+<0.01%) ⬆️
3.9 96.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c4deszes c4deszes merged commit fbf34fe into master Apr 28, 2024
14 of 15 checks passed
@c4deszes c4deszes deleted the feature/signal-overlapping-error-message branch April 28, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ldf/frames Related to LIN frames
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlapping signal error doesn't contain proper signal name
1 participant