Add label to mobxpromise instance for debugging purposes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
commented
Oct 24, 2022
| @@ -43,6 +43,8 @@ export type MobxPromiseInputParams<R> = { | |||
| * It will not be called for out-of-date promises. | |||
There was a problem hiding this comment.
@onursumer this is the only file that need be reviewed. the rest are generated by build.
onursumer
reviewed
Oct 24, 2022
src/MobxPromise.ts
Outdated
Comment on lines
156
to
158
| if (localStorage.debugMP) { | ||
| debugger; | ||
| } |
There was a problem hiding this comment.
Is this debugger on purpose? Do we need this because source code is not mapped?
alisman
commented
Oct 25, 2022
| // we need to | ||
| if (this.isComplete === false) { | ||
| /*@ts-ignore*/ | ||
| if (this.onPrematureRead) this.onPrematureRead.call(this); |
There was a problem hiding this comment.
@onursumer this is a little nicer. i need to be able to execute some stuff when this happens so i can now configure that in code by tacking on a method to prototype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.