use .toLocaleString() to return number with max and min signigicant d…

…igits
cBioPortal · Jan 16, 2020 · 1e65cb8 · 1e65cb8
1 parent 727017a
commit 1e65cb8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/packages/react-mutation-mapper/src/component/gnomad/GnomadFrequency.tsx b/packages/react-mutation-mapper/src/component/gnomad/GnomadFrequency.tsx
@@ -145,11 +145,14 @@ export default class GnomadFrequency extends React.Component<GnomadFrequencyProp
                 display = <span>0</span>;
             } else {
                 // show frequency as number with 4 significant digits
-                var significantDigitsFormatter = new Intl.NumberFormat("en", { 
-                    minimumSignificantDigits: 1,
-                    maximumSignificantDigits:4
-                });
-                display = <span>{significantDigitsFormatter.format(result['Total'].alleleFrequency)}</span>;
+                display = (
+                    <span>
+                        {result['Total'].alleleFrequency.toLocaleString(undefined, {
+                            maximumSignificantDigits: 4,
+                            minimumSignificantDigits: 1,
+                        })}
+                    </span>
+                );
             }
 
             overlay = () => <GnomadFrequencyTable data={sorted} gnomadUrl={gnomadUrl} />;

diff --git a/packages/react-mutation-mapper/src/component/gnomad/GnomadFrequencyTable.tsx b/packages/react-mutation-mapper/src/component/gnomad/GnomadFrequencyTable.tsx
@@ -6,7 +6,6 @@ import {GnomadSummary} from "../../model/GnomadSummary";
 import ColumnHeader from "../column/ColumnHeader";
 
 import "./gnomadFrequencyTable.scss";
-import { significantDigits } from "../../util/FormatUtils";
 
 export interface IGnomadFrequencyTableProps
 {
@@ -21,7 +20,14 @@ export function frequencyOutput(frequency: number) {
     }
     else {
         // show frequency as number with 4 significant digits
-        return <span>{significantDigits(frequency, 4)}</span>;
+        return (
+            <span>
+                {frequency.toLocaleString(undefined, {
+                    maximumSignificantDigits: 4,
+                    minimumSignificantDigits: 1,
+                })}
+            </span>
+        );
     }
 }