fix bug where profiled in tracks were appearing when they shouldnt #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamabeshouse
force-pushed
the
profiled-in
branch
from
f82de17
to
f0a77f5
Compare
alisman
reviewed
Sep 18, 2018
| @@ -52,11 +56,26 @@ export function makeProfiledInClinicalAttributes( | |||
| } | |||
| } | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
i think this whole thing needs testing. i mean, if anything does, it's this, right?
There was a problem hiding this comment.
good point, I covered it with a screen shot but Ill add a case for this to the spec file
adamabeshouse
force-pushed
the
profiled-in
branch
from
f0a77f5
to
4c731d1
Compare
… shouldnt Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
alisman
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.