Upgrade to node LTS 8.12.0 / npm 6.4.1 #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help early detection of missing / outdated dependencies.
This allows us to use `npm ci`, which doesn't change package.json or package-lock.json and fails when installation can't be completed with the specified dependencies. Also ran npm audit which upgraded a few dependencies. Furthermore upgrade node-sass, because the binary from the old version is gone.
inodb
commented
Oct 11, 2018
| @@ -1,85 +0,0 @@ | |||
| language: node_js | |||
inodb
commented
Oct 11, 2018
| @@ -36,7 +36,7 @@ | |||
| </goals> | |||
| <!-- Optional configuration which provides for running any npm command --> | |||
| <configuration> | |||
| <arguments>install --production</arguments> | |||
| <arguments>ci --only=production</arguments> | |||
There was a problem hiding this comment.
use npm ci for jitpack as well (jitpack is actually for java, which is why we are using a pom file)
inodb
commented
Oct 11, 2018
| @@ -139,12 +139,12 @@ | |||
| "mobx-react-router": "^3.1.2", | |||
| "mobx-utils": "^2.0.1", | |||
| "mobxpromise": "^1.3.1", | |||
| "node-sass": "^4.3.0", | |||
| "node-sass": "^4.9.3", | |||
There was a problem hiding this comment.
this upgrade was necessary because the binary was missing for 4.3.0
There is some shifting of the fonts, because we are using a new circleci image with perhaps slightly different chrome version.
adamabeshouse
approved these changes
Oct 11, 2018
|
Nice! Thanks @inodb 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use
npm ci(https://docs.npmjs.com/cli/ci), which doesn't change package.json orpackage-lock.json and fails when installation can't be completed with the
specified dependencies. Also ran
npm auditwhich upgraded a few dependencies.Furthermore upgrade
node-sass, because the binary from the old version is gone.UPDATE
Needed to update the screenshots. There is some shifting of the fonts and the scrollbar looks a bit different, because we are using a new circleci image with prolly a slightly different chrome version.