Mutationstab: change to banner alert #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
reviewed
Nov 9, 2018
| @@ -51,6 +53,12 @@ export default class Mutations extends React.Component<IMutationsPageProps, {}> | |||
| onToggle={this.onToggleOql} | |||
| /> | |||
| </div> | |||
|
|
|||
| {this.props.store.mutationMapperStores.isComplete && ! this.props.store.mutationMapperStores.result[this.mutationsGeneTab].dataStore.showingAllData && | |||
| <div> | |||
There was a problem hiding this comment.
you probably don't need extra div around this
There was a problem hiding this comment.
also, try putting this above inside the tabMessageContainer div.
There was a problem hiding this comment.
Thanks, I just fixed it.
alisman
approved these changes
Nov 9, 2018
dippindots
force-pushed
the
Mutationstab_Moving_Filters_Message
branch
from
71ff5df
to
7ff5f47
Compare
alisman
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to alert to the uniform banner alert.
Fix cBioPortal/cbioportal/#5183