Handle invalid genes error by directing use to correct query in query… #1894
Conversation
| } | ||
|
|
||
| @observable.ref store: QueryStore; |
There was a problem hiding this comment.
you only want to set store on init?
There was a problem hiding this comment.
the basic idea is that when i show the the query component, i want to create a store for that session/lifecycle of the component. it cannot be replaced/updated by anything. and it gets throw out on close. i could model this above in the page, but this seems cleaner to me. let me know what you think.
There was a problem hiding this comment.
just for clarity i think this shouldnt be observable
| @@ -141,6 +140,16 @@ export default class QuerySummary extends React.Component<{ routingStore:Extende | |||
| getGAInstance()('send', 'event', 'resultsView', 'query modified'); | |||
| } | |||
|
|
|||
| @computed get queryForm(){ | |||
| return <div style={{marginTop:10}}> | |||
There was a problem hiding this comment.
welcome to the dark side 😈
There was a problem hiding this comment.
why is this the dark side? jsx from @computed? if so, i've long been guilty. the darkside is jsx from mobxpromise.
| } | ||
| }); | ||
|
|
||
| @computed get genesInvalid(){ |
There was a problem hiding this comment.
should we also catch invalid profiles/studies/overall query, like QueryStore.submitError?
There was a problem hiding this comment.
lets discuss at standup. i happen to know from sentry that we often get invalid genes. not sure if that's true for those other params.
We get a handful of errors each day where users have outdated links with invalid genes. This PR directs users back to query page to fix things.