Do not retrieve tags for virtual studies #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
reviewed
Jul 18, 2019
| }; | ||
|
|
||
| @observer | ||
| default class BuildOverlay extends React.Component<BuildOverlayTooltipProps, {}> { | ||
| @observable readonly studyMetadata = remoteData({ | ||
| invoke: async () => { | ||
| if (this.props.isVirtualStudy) { |
There was a problem hiding this comment.
you should just deal with this condition down in the render method instead of muddying the promise with it.
alisman
reviewed
Jul 18, 2019
| @@ -43,12 +44,16 @@ export type StudyTagsTooltipProps = { | |||
| export type BuildOverlayTooltipProps = { | |||
| studyDescription: string; | |||
| studyId: string; | |||
| isVirtualStudy: boolean; | |||
| }; | |||
|
|
|||
| @observer | |||
| default class BuildOverlay extends React.Component<BuildOverlayTooltipProps, {}> { | |||
There was a problem hiding this comment.
While we're at it, might as well change this to StudyInfoOverlay
oplantalech
force-pushed
the
fix_tags_in_virtual_studies
branch
from
53a1d1e
to
91540c7
Compare
alisman
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Fix for cBioPortal/cbioportal#6285. There is a bug when using virtual studies and hovering the info icon in the query page: the endpoint
/studies/{studyId}/tagsreturns an error after attempting to retrieve the tags given the virtual study ID (instead of an expected non-virtual study ID). Since virtual studies can be made of multiple studies, I think the best way to deal with the error is not to retrieve tags for virtual studies. Feel free to comment if you think there is a better solution to deal with the issue.