Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user announcement and tour message (on study page) #2670

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

alisman
Copy link
Collaborator

@alisman alisman commented Sep 6, 2019

No description provided.

<WrappedTour/>
</InfoBeacon>
</If>
{/*<If condition={!isWebdriver()}>*/}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving this in as poor man's documentation for our next usage of this. where else does this belong? ReadME? Wiki?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could maybe add it here in a new section? https://docs.cbioportal.org/4.-development/release-procedure. Prolly good to add some comment above this as well, like "uncomment to show a green info beacon at the top of the page, useful to highlight a new feature defined in Usermessage.tsx".

@alisman alisman merged commit 2f14ec5 into cBioPortal:master Sep 9, 2019
@alisman alisman deleted the removeAnnouncement branch September 9, 2019 19:31
jagnathan pushed a commit to pughlab/cbioportal-frontend that referenced this pull request Jan 25, 2022
Remove user announcement and tour message (on study page)
@Danish-Belal
Copy link

Kindly assign this to me , i want to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants